Skip to content

fix: fix the UI jumping issue when rotateCropBoxFor90DegreeRotation = false #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoyingtao wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fix the UI jumping issue when rotateCropBoxFor90DegreeRotation = false #490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5c52f
fix: fix the UI jumping issue when rotateCropBoxFor90DegreeRotation =…
guoyingtao Jan 7, 2026
36d1cfa
Update Example/DemoViewController.swift
guoyingtao Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Example/DemoViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class DemoViewController: UIViewController {
config.cropViewConfig.cropActivityIndicator = CustomWaitingIndicator(frame: indicatorFrame)
config.cropToolbarConfig.toolbarButtonOptions = [.clockwiseRotate, .reset, .ratio, .autoAdjust, .horizontallyFlip]

// config.cropViewConfig.rotateCropBoxFor90DegreeRotation = false
Comment thread
guoyingtao marked this conversation as resolved.
Outdated
if let transformation = transformation {
config.cropViewConfig.presetTransformationType = .presetInfo(info: transformation)
}
Expand Down
12 changes: 4 additions & 8 deletions Sources/Mantis/CropView/CropView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,7 @@ final class CropView: UIView {

func updateCropBoxFrame(withTouchPoint touchPoint: CGPoint) {
let imageContainerRect = imageContainer.convert(imageContainer.bounds, to: self)
let imageFrame = CGRect(x: cropWorkbenchView.frame.origin.x - cropWorkbenchView.contentOffset.x,
y: cropWorkbenchView.frame.origin.y - cropWorkbenchView.contentOffset.y,
width: imageContainerRect.size.width,
height: imageContainerRect.size.height)

let touchPoint = confineTouchPoint(touchPoint, in: imageFrame)
let touchPoint = confineTouchPoint(touchPoint, in: imageContainerRect)
let contentBounds = getContentBounds()
let cropViewMinimumBoxSize = cropViewConfig.minimumCropBoxSize
let newCropBoxFrame = viewModel.getNewCropBoxFrame(withTouchPoint: touchPoint,
Expand Down Expand Up @@ -599,9 +594,9 @@ extension CropView {
isManuallyZoomed = true
}

func makeSureImageContainsCropOverlay() {
func makeSureImageContainsCropOverlay(animated: Bool = true) {
if !imageContainer.contains(rect: cropAuxiliaryIndicatorView.frame, fromView: self, tolerance: 0.25) {
cropWorkbenchView.zoomScaleToBound(animated: true)
cropWorkbenchView.zoomScaleToBound(animated: animated)
}
}

Expand Down Expand Up @@ -934,6 +929,7 @@ extension CropView: CropViewProtocol {
updatePositionFor90Rotation(by: rotateAngle + viewModel.radians)
} else {
adjustWorkbenchView(by: rotateAngle + viewModel.radians)
makeSureImageContainsCropOverlay(animated: false)
}
}

Expand Down