Skip to content

Add support for multiple asset types#485

Open
maxwofford wants to merge 3 commits into
mainfrom
asset-support-check
Open

Add support for multiple asset types#485
maxwofford wants to merge 3 commits into
mainfrom
asset-support-check

Conversation

@maxwofford

Copy link
Copy Markdown
Member

As discussed with @grymmy and @karamassie, this is a nice-to-have for after launch, but not required for launch. This is related to #482

This adds support for smartly choosing the asset to import based on browser compatibility. It also includes an example, switching the import string sounds.music.intro: '.mp3' to the array sounds.music.intro: ['.m4a', '.mp3'].

It's still backwards compatible with the previous import file, but now switching imports to an array like that will to through them first to last, check if the file is compatible with the current browser (using howler.js, so we don't have to maintain it) and import the first file that works. It can even be extended to something like sounds.music.intro: ['.webm', '.ogg', '.m4a', '.mp3'] as long as all 4 files are in the assets folder. In this example, we go from most efficient compression (but less supported) formats (.webm) sliding to large filesize but compatible with any browser formats (.mp3).

@vercel

vercel Bot commented May 4, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sinerider ✅ Ready (Inspect) Visit Preview May 8, 2023 9:46pm

@camdan-me

Copy link
Copy Markdown
Member

This sounds like it'd be trivial to complete, except for file conversion- what's the plan there?

@JosiasAurel

Copy link
Copy Markdown
Member

what's the status of this pr? could this make it into main?

@polytroper

Copy link
Copy Markdown
Collaborator

Ah, damn sorry I let this languish. And I just closed two PRs because we don’t have exactly this functionality. Sorry @maxwofford @JosiasAurel 🤦‍♂️

@Captainexpo-1 let’s take a look at completing this, it’d be awesome if we could gracefully fall back from OGG sound files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants