Add hours validation and test

[junjun107]



• Hours cannot be blank
• Closing time cannot be before opening time
• Opening time cannot be same as closing time

Also updated test for longitude and latitude fail cases (long too low, too high, and lat too low, too high)

[SAUMILDHANKAR]

Thanks @junjun107 for the tests. This is my next learning assignment. 👍

Nit picky: For longitude validation, when I type 500 I get longitude must be less than or equal to -117.6462 and then I enter -500 to get longitude must be greater than or equal to -118.9517. It could be just me but if we prompt the user the limits every time maybe that can be easier?

Playwright tests as part of workflow seem to be passing. I will look into if we can run these tests manually as well.

[junjun107]

Good point. @SAUMILDHANKAR I think error message with a range is more clear. Like this screenshot below

[SAUMILDHANKAR]

Thank you. Looks good to me.

[junjun107]

Going to add a warning toast when there is any error on the page when user click on save progress button.

[junjun107]

I added a simple toast message when user clicks on Save Progress when there is error messages in the form.
"Please fix the errors in the form before save progress.",

[SAUMILDHANKAR]

Thanks @junjun107 This was much needed. Some places I have seen that once you click save it takes you to the place on the screen with the first validation error. Will that be helpful? We can discuss in the meeting and I can create an issue for that if we want or maybe there is already an issue for that I will check.

[junjun107]

Team Request: Change color of toast to warning

[junjun107]

Added info" | "warning" | "success" | "error" type to toast/Alert and matched them with theme color.

export type ToastContextProps = {
  toast: {
    message: string;
    type?: "info" | "warning" | "success" | "error";
  };
  setToast: React.Dispatch<
    React.SetStateAction<{
      message: string;
    }>
  >;
};

Now error toast is in red