Skip to content

fixed name of announcement toggle - #2519

Merged
SAUMILDHANKAR merged 1 commit into
developfrom
saumildhankar-2499-fix-announcement-toggle-name
Aug 12, 2025
Merged

fixed name of announcement toggle#2519
SAUMILDHANKAR merged 1 commit into
developfrom
saumildhankar-2499-fix-announcement-toggle-name

Conversation

@SAUMILDHANKAR

@SAUMILDHANKAR SAUMILDHANKAR commented Jul 24, 2025

Copy link
Copy Markdown
Member
toggle.name.error.mp4
  • After
no.useeffect.mp4

@SAUMILDHANKAR
SAUMILDHANKAR force-pushed the saumildhankar-2499-fix-announcement-toggle-name branch from 789ea8e to edfbd5a Compare July 24, 2025 03:50
Comment thread client/src/components/Admin/Announcements.jsx Outdated
@SAUMILDHANKAR
SAUMILDHANKAR marked this pull request as ready for review July 24, 2025 03:55
Comment thread client/src/components/Admin/Announcements.jsx Outdated
Comment thread client/src/components/Admin/Announcements.jsx Outdated
@SAUMILDHANKAR
SAUMILDHANKAR force-pushed the saumildhankar-2499-fix-announcement-toggle-name branch 2 times, most recently from 8d233de to 3a1671d Compare August 4, 2025 21:30
@SAUMILDHANKAR
SAUMILDHANKAR marked this pull request as draft August 4, 2025 21:30
@SAUMILDHANKAR
SAUMILDHANKAR marked this pull request as ready for review August 4, 2025 22:05
Comment thread client/src/components/Admin/Announcements.jsx Outdated
@SAUMILDHANKAR
SAUMILDHANKAR marked this pull request as draft August 11, 2025 01:38
@SAUMILDHANKAR
SAUMILDHANKAR force-pushed the saumildhankar-2499-fix-announcement-toggle-name branch 2 times, most recently from f8aa003 to 2a5873f Compare August 12, 2025 02:27
fixed toggle and shuffle

moved data transformation to custom hook

removed comment

removed states and useeffect
@SAUMILDHANKAR
SAUMILDHANKAR force-pushed the saumildhankar-2499-fix-announcement-toggle-name branch from 2a5873f to f6be7aa Compare August 12, 2025 04:23
@SAUMILDHANKAR
SAUMILDHANKAR marked this pull request as ready for review August 12, 2025 04:31
@SAUMILDHANKAR

Copy link
Copy Markdown
Member Author

Thanks a lot @hanapotski for helping me with this PR.

@SAUMILDHANKAR
SAUMILDHANKAR merged commit ff38a1a into develop Aug 12, 2025
1 check passed
@SAUMILDHANKAR
SAUMILDHANKAR deleted the saumildhankar-2499-fix-announcement-toggle-name branch August 12, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable toggle on announcement and edit screens Fix naming of announcement toggle

2 participants