Skip to content

2565 fix announcements schema - #2566

Merged
Giolii merged 3 commits into
developfrom
2565-fix-announcements-schema
Oct 14, 2025
Merged

2565 fix announcements schema#2566
Giolii merged 3 commits into
developfrom
2565-fix-announcements-schema

Conversation

@Giolii

@Giolii Giolii commented Oct 7, 2025

Copy link
Copy Markdown
Member

Fixes #2565

Summary

  • Fixed TypeScript compilation error in announcements schema

Problem

  • TypeScript compilation failed
  • The required array was incomplete
  • Schema required id and created_at fields which are auto-generated by the database

Solution

  • Use Omit<Announcement, "id" | "created_at"> for the POST schema
  • Remove nullable: true
  • Remove id and created_at from properties since they're auto-generated

Test plan

  • npm run typecheck passes without errors
  • Creating a new announcement through the admin UI works without errors
  • Test and Build passes without errors

@Giolii Giolii assigned Giolii and unassigned Giolii Oct 9, 2025

@junjun107 junjun107 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Giolii
Giolii merged commit 20c02d5 into develop Oct 14, 2025
1 check passed
@Giolii
Giolii deleted the 2565-fix-announcements-schema branch October 14, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript build fails

2 participants