Skip to content

Add aria-label to filter panel close button #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olitreadwell wants to merge 1 commit into from
Closed

Add aria-label to filter panel close button #2851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/components/FoodSeeker/SearchResults/ResultsFilters/FilterPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ const FilterPanel: FC<FilterPanelProps> = ({ mealPantry, filterCount }) => {
{`${filterCount} ${filterCount === 1 ? "Location" : "Locations"}`}
</Typography>
{isDesktop ? (
<IconButton onClick={handleDrawerClose}>
<IconButton aria-label="Close filters" onClick={handleDrawerClose}>
<CloseIcon />
</IconButton>
) : (
Expand Down
14 changes: 14 additions & 0 deletions client/tests/organizations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,18 @@ test.describe("Organizations", () => {
await expect(page.getByText("Stakeholder 2")).toBeVisible();
await expect(page.getByText("Stakeholder 3")).toBeHidden();
});

test("filter panel close button has an accessible name and closes the panel", async ({
page,
}) => {
await mockRequests(page);
await page.goto("/organizations");
await page.getByRole("button", { name: "More Filters" }).click();

const closeFilters = page.getByRole("button", { name: "Close filters" });
await expect(closeFilters).toBeVisible();

await closeFilters.click();
await expect(closeFilters).toBeHidden();
});
});