Update Table: User | Model | API | Test cases#616
Open
Ruchitha12 wants to merge 1 commit intohackforla:mainfrom
Open
Update Table: User | Model | API | Test cases#616Ruchitha12 wants to merge 1 commit intohackforla:mainfrom
Ruchitha12 wants to merge 1 commit intohackforla:mainfrom
Conversation
fyliu
force-pushed
the
feature/update_user
branch
from
cc66bb1 to
c93f0e2
Compare
Member
|
I rebased to main and updated the migration file numbering, making sure tests and linters are passing. I haven't looked at the code yet. |
fyliu
requested changes
Feb 12, 2026
Member
fyliu
left a comment
fyliu
left a comment
There was a problem hiding this comment.
Thanks for working on this! I think we need some clarification on the requirements for this to be sure. I will bring it up at the meeting.
Comment on lines
+114
to
+119
| intake_target_skills = ArrayField( | ||
| base_field=models.IntegerField(), | ||
| default=list, | ||
| blank=True, | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
I think this might need to be a many to many reference to another table. Let me ask to make sure.
Member
There was a problem hiding this comment.
Linking to the clarification from the meeting. This does look like the structure that's intended. Let me make sure there's nothing significantly better for this.
github-project-automation
bot
moved this from 👀PR being reviewed
to PR changes requested
in P: PD: Project Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #601
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)