Conversation
fyliu
moved this to PR Needs review (automated column, do not place items here manually)
in P: PD: Project Board
fyliu
moved this from PR Needs review (automated column, do not place items here manually)
to 👀PR being reviewed
in P: PD: Project Board
There was a problem hiding this comment.
Great for the most part. Just a few little details need fixing.
-
Building the image generates a new migration file that should've been added.
-
the 3 fields that turned into FKs need tests.
-
The project_leads is missing tests. But as a many to many field, I think it's better to split it into a separate issue to work on. I think I'll need to look at a few ways of doing this and choose one that makes sense for us.
github-project-automation
bot
moved this from 👀PR being reviewed
to PR changes requested
in P: PD: Project Board
removing completed_on Co-authored-by: Fang Yi Liu <fyliu@users.noreply.github.com>
commit suggestion Co-authored-by: Fang Yi Liu <fyliu@users.noreply.github.com>
added `from django.conf import settings`
for more information, see https://pre-commit.ci
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
altered imports ``` import uuid + import textwrap + from django.conf import settings ```
for more information, see https://pre-commit.ci
altering models.py ``` - "User", # Replace "User" with your specific User model name if different + settings.AUTH_USER_MODEL ``` Co-authored-by: Fang Yi Liu <fyliu@users.noreply.github.com>
|
@drakeredwind01 I looked through the tables and fields spreadsheet and the ERD for the database. It looks like these fields being foreign keys pointing to ProjectUrl objects is correct. The names should be without the "_id" in them I think. There's something unusual about these fields, and I'll try to explain with one of them. For the google_drive_id, we have a ProjectUrl object in the database that says this project has a Google Drive link to the URL. That has the complete information without the So we can do something like this on just the Project object without having to look it up in the ProjectUrl table:
|
fyliu
left a comment
fyliu
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Sorry to do this, but can you remove the _id from the foreign key fields?
3 participants
Fixes #607
What changes did you make?
github_org_idForeignKeyProjectUrlgithub_primary_repo_idForeignKeyProjectUrlgoogle_drive_idForeignKeyProjectUrlcompleted_onDateFieldproject_leadsManyToManyFieldUserWhy did you make the changes (we will use this info to test)?
for issue Update Table: project #607