2964: Project Workflow (Create/Edit ) - Add Pagination Component with clickable pages#3086
Open
ijoel wants to merge 6 commits intohackforla:developfrom
Open
2964: Project Workflow (Create/Edit ) - Add Pagination Component with clickable pages#3086ijoel wants to merge 6 commits intohackforla:developfrom
ijoel wants to merge 6 commits intohackforla:developfrom
Conversation
- handle resets if the user opens a different project - update mapping logic to construct array up to highestPage
The state to track wizard page advancement, highestPage, was lifted to facilitate passing a boolean to hide the discover tooltips component within its parent ProjectDescriptions. This is a reasonable workaround, given that tooltip should the user open a project, advance pagination forward, and finally return to the first page of the wizards and discover that the tooltips component is hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes did you make?
The changes enhance the pagination component of the View/Edit Project workflow. The user now has the ability to directly navigate to a page previously visited by clicking the desired page navigation button.
The updated behavior matches the desired state specified on the issue
Why did you make the changes (we will use this info to test)?
The changes achieve the requested enhancements to the pagination component.
Issue-Specific User Account
Tested in an unauthentication session and with an authenticated user: ladot@dispostable.com
Screenshots of Proposed Changes Of The Website
Visuals before changes are applied
Visuals after changes are applied