Kk/3245 input and rules fix - #3437
Open
KentKawa wants to merge 5 commits into
Open
Conversation
entrotech
requested changes
Aug 18, 2026
Member
There was a problem hiding this comment.
Here is a screen shot of what I'm getting:
The things that aren't quite right yet:
- The email field is filled out correctly, but the validation messages below the email text box are still showing.
- The Create Account button is not centered horizontally.
- The Create Account button should be disabled, since the password re-entry rule is not satisfied.
- When there are multiple validation messages under an input control, they do not appear to be "double spaced" vertically. IMO, "double-spacing" is too much - maybe something like 1.5rem would spllit the difference.
Member
Author
|
@entrotech |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes did you make?
Why did you make the changes (we will use this info to test)?
Of note
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Outline for password fields
Email rules should disappear after successful completion
Once the email is entered correctly, and the user changes the focus onto the primary password field, the rules under the correctly entered non focused email field should go away. If you return focus to the email field they should come back.
You can see that it still persists even when every field is entered correctly
Spacing for rules
Create Account should centered and grayed out until all fields pass
Visuals after changes are applied
Outline for password fields
Email rules disappear after successful completion
Spacing for rules
Create Account centered and grayed out until all fields pass