Skip to content

Kk/3245 input and rules fix - #3437

Open
KentKawa wants to merge 5 commits into
developfrom
kk/3245-input-and-rules-fix
Open

Kk/3245 input and rules fix#3437
KentKawa wants to merge 5 commits into
developfrom
kk/3245-input-and-rules-fix

Conversation

@KentKawa

@KentKawa KentKawa commented Aug 13, 2026

Copy link
Copy Markdown
Member

What changes did you make?

  • Fixed tab highlighting on password input and button
  • Fixed name string error showing wrong rule
  • Fixed spacing on rules
  • Fixed email rules not going away after they were correct
  • Submit button is now centered and disabled until all inputs are valid

Why did you make the changes (we will use this info to test)?

  • Input from testing

Of note

  • It was pointed out in the issue that when you tab or focus an input the rule shows up with no icons. This is not a bug. This follows the Figma file designs. No icons should appear until something fills the input.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Outline for password fields Image Image
Email rules should disappear after successful completion

Once the email is entered correctly, and the user changes the focus onto the primary password field, the rules under the correctly entered non focused email field should go away. If you return focus to the email field they should come back.

Image

You can see that it still persists even when every field is entered correctly

Image
Spacing for rules Image Image
Create Account should centered and grayed out until all fields pass Image

Visuals after changes are applied

Outline for password fields Screenshot 2026-08-12 at 6 44 15 PM Screenshot 2026-08-12 at 6 43 01 PM
Email rules disappear after successful completion Screenshot 2026-08-12 at 6 49 41 PM
Spacing for rules Screenshot 2026-08-12 at 6 38 17 PM
Create Account centered and grayed out until all fields pass Screenshot 2026-08-12 at 6 39 19 PM

@KentKawa
KentKawa requested a review from entrotech August 13, 2026 01:59
@KentKawa KentKawa added role: front-end Front End Developer level: easy labels Aug 13, 2026

@entrotech entrotech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a screen shot of what I'm getting:

Image

The things that aren't quite right yet:

  • The email field is filled out correctly, but the validation messages below the email text box are still showing.
  • The Create Account button is not centered horizontally.
  • The Create Account button should be disabled, since the password re-entry rule is not satisfied.
  • When there are multiple validation messages under an input control, they do not appear to be "double spaced" vertically. IMO, "double-spacing" is too much - maybe something like 1.5rem would spllit the difference.

@KentKawa

Copy link
Copy Markdown
Member Author

@entrotech
I think something might be wrong with the branch because it looks like none of the commits are on the branch you pulled. Here is what a screenshot of what I am getting locally.
Screenshot 2026-08-18 at 12 47 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: Update the new account creation workflow

2 participants