Fix page refcount leak in RangeIterator.TrySeek - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RangeIterator.TrySeek/TrySeekAsynccallTreeWalker.TrySearch, which returns the found leaf page with a newly retained reference. When seeking to a key on the page the iterator already holds (currentPage == page), that new reference was neither stored nor released, so the page's refcount grew by one on every such seek. A leaked refcount prevents the page buffer from ever being disposed after cache eviction.Fix
Release the duplicate reference when the seek lands on the page the iterator already holds.
Test
Added a regression test that seeks the same key repeatedly and asserts the refcount stays balanced (1 held by the page cache + 1 by the iterator). It fails with refcount=4 before this fix.
🤖 Generated with Claude Code