[batch/ui] Improved timeout error messages - #15620
Open
grohli wants to merge 3 commits into
Open
Conversation
grohli
commented
Jul 31, 2026
| if err.status == 401: | ||
| body = getattr(err, 'body', None) | ||
| if body: | ||
| raise web.HTTPUnauthorized(text=body) |
Contributor
Author
There was a problem hiding this comment.
Note to self: make this inactive-specific through some means (rather than just showing every 401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Users are meant to receive an informative error message if they attempt to use Hail while their account has been marked as inactive. Currently, the intended error message does not make its way to users for a variety of reasons (for example, users are attempting to use Hail in a session id-based setting like a Jupyter notebook, or the error message is swallowed by other auth checks we make along the way).
This PR adds explicit inactive user checks for i) login id and hail identity id and ii) session id, whereby we're now able to handle and raise appropriate errors if a user is inactive.
Security Assessment
Impact Rating
Impact Description
This PR adds new auth checks specific to inactive users. However, nothing has been removed from our already existing checks (relating to
get_userinfo()), and users should still be subject to the same authentication scrutiny as before.Appsec Review