Allow custom nginx configuration - #139
Open
woodspire wants to merge 4 commits into
Open
Conversation
allow to use a custom nginx config file
Specify how to use new switch
oups. Map folder instead of file
nekatak
approved these changes
Sep 7, 2019
There was a problem hiding this comment.
I agree with these changes. I have many issues caused from the nginx in the seafile container. For example running another reverse proxy before you cannot update anyhow client IPs and you cannot allow custom timeouts. This is a very useful change.
Of course an easy workaround for anyone interested to fix any issues is to simply mount a custom /etc/nginx/nginx.conf with the config and not include sites-enabled folder in it. Same thing as fix above more or less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow to use a custom nginx config file
building the docker container with:
-v /nginx.seafile.conf:/etc/nginx/sites-enabled/nginx.seafile.conf
-e SEAFILE_SERVER_NGINX_CONF_CUSTOM=1