Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

docs: tighten ADR-001 (drop redundant section, de-dupe ecosystem list)#39

Open
hampsterx wants to merge 1 commit into
masterfrom
docs/tighten-adr-001
Open

docs: tighten ADR-001 (drop redundant section, de-dupe ecosystem list)#39
hampsterx wants to merge 1 commit into
masterfrom
docs/tighten-adr-001

Conversation

@hampsterx

Copy link
Copy Markdown
Owner

Summary

Tighten ADR-001 from 75 lines to ~46. The ADR was carrying 2x the prose of the codex-mcp-bridge equivalent (which is 35 lines and says the same thing) for no extra signal.

Changes

  • Drop section "Why drop rather than reshape". Its surviving content lives in §Alternatives as the first bullet ("Reshape review to accept caller-supplied prompts"). Two slots arguing the same rejection was duplication.
  • De-dupe the ecosystem list. Previously appeared in §Context (full descriptions), §Decision (priority-ordered), and partially in §Cross-references (with announcement dates). Now once, in §Decision.
  • Cut the §Cross-references timeline. Announcement dates ("Skills feature: announced 28 Jan 2026", "Subagents: announced 15 Apr 2026"), repo paths in tree form. ADRs link, they don't archive timelines. README and CHANGELOG carry these.
  • Cut hand-wavy phrases: "Bridges age badly when they invent surface that upstream sidesteps", "stays scoped to its stateful tools" (gemini's tools aren't stateful in the way claude's listSessions is; the line was borrowed from the workspace ADR and didn't fit here).
  • Drop the "if a concrete audience emerges, reconsider" footer. Applies to every ADR; no signal.
  • Collapse alternatives into 1-line bullets to match codex and claude.
  • Add explicit version transition + BREAKING-marker note in Consequences (matches claude ADR Consequences format).

Test plan

  • No code changes; nothing to build/test.
  • Decision rationale unchanged: drop review and assess, gemini ecosystem covers review, assess has no consumer without review.
  • All ecosystem links preserved.
  • Markdown renders cleanly.

The ADR was 75 lines vs codex's 35 and carried 2x the prose for no
extra signal. Tightened to ~46 lines:

- Drop section "Why drop rather than reshape"; surviving content
  lives in Alternatives as the first bullet
- De-dupe ecosystem list: previously appeared in Context, Decision,
  and partially in Cross-references. Now once in Decision.
- Cut Cross-references timeline (announcement dates, doc paths in
  tree form); README and CHANGELOG carry these
- Cut hand-wavy phrases ("Bridges age badly when they invent surface
  that upstream sidesteps", "stays scoped to its stateful tools")
- Drop the "if a concrete audience emerges, reconsider" footer; that
  applies to every ADR and adds no signal
- Collapse alternatives into 1-line bullets to match codex/claude
- Add explicit version transition + BREAKING-marker note in
  Consequences (matches claude ADR Consequences format)
@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@hampsterx has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 49 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 31 minutes and 49 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 058e4f4c-8ea6-49d5-92ce-5346a14fda57

📥 Commits

Reviewing files that changed from the base of the PR and between ae5042d and 92bb451.

📒 Files selected for processing (1)
  • docs/decisions/001-remove-review-and-assess-tools.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/tighten-adr-001

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hampsterx

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@hampsterx

Copy link
Copy Markdown
Owner Author

@coderabbitai review full

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown

@hampsterx Sure! I'll kick off a full review of the PR now.

✅ Actions performed

Full review triggered.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant