improve presence listener interface - #23
Merged
Merged
Conversation
* added code to pass updated version to LongPollListner * Extern kysely-ctl and jiti to fix dynamic require in parcel (#22) * moved version and seen into listener * format fix * added oxc formatter for vscode --------- Co-authored-by: Shane Friedman <smoores-gpg@friedmans.us>
smoores-dev
reviewed
May 15, 2026
Comment on lines
+66
to
+67
| let options = signal ? { signal } : {}; | ||
| for await (const newCommits of this.listener.listen(editorState, options)) { |
Member
There was a problem hiding this comment.
Oh right, forgot I left this in by accident. This can just be:
Suggested change
| let options = signal ? { signal } : {}; | |
| for await (const newCommits of this.listener.listen(editorState, options)) { | |
| for await (const newCommits of this.listener.listen(editorState, { signal )) { |
Contributor
Author
There was a problem hiding this comment.
Typescript gets made at me when I do that
Argument of type '{ signal: AbortSignal | undefined; }' is not assignable to parameter of type '{ signal?: AbortSignal; }'.
Types of property 'signal' are incompatible.
Member
There was a problem hiding this comment.
Oh, yeah. Just change the type of listener.listen to be AbortSignal | undefined
|
|
||
| import { | ||
| LongPollListener, | ||
| LongPollListener as CollabLongPollListner, |
Member
There was a problem hiding this comment.
Suggested change
| LongPollListener as CollabLongPollListner, | |
| LongPollListener as CollabLongPollListener, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.