Fix in-place reverse messing up position rebasing - #16
Merged
smoores-dev merged 2 commits intoAug 27, 2025
Merged
Conversation
VV-EE
force-pushed
the
fix-size-error-multi-step-tr
branch
2 times, most recently
from
July 23, 2025 21:18
83ef720 to
e93851c
Compare
smoores-dev
reviewed
Jul 31, 2025
smoores-dev
left a comment
smoores-dev
left a comment
Member
There was a problem hiding this comment.
Thanks for this, great catch. One little note about the new eslint disable comment, otherwise this looks good to me
| isSuggestChangesEnabled(this.state) && | ||
| !tr.getMeta("history$") && | ||
| !tr.getMeta("collab$") && | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access |
Member
There was a problem hiding this comment.
This doesn't seem right — We type cast the meta object on line 219 above to have this property, so I don't know why it would be an unsafe member access. Also, locally I do not need this disable comment, eslint does not complain about this line for me.
smoores-dev
previously approved these changes
Aug 27, 2025
smoores-dev
force-pushed
the
fix-size-error-multi-step-tr
branch
from
August 27, 2025 14:21
49d1a97 to
6f8c20a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #15 which fixes an error, after that this issue is revealed.
Added test for proof.