Remove doubled spaces when accepting deletions - #17
Merged
smoores-dev merged 2 commits intoAug 27, 2025
Merged
Conversation
smoores-dev
reviewed
Jul 31, 2025
Comment on lines
+73
to
+79
| const prevChar = tr.doc.textBetween( | ||
| deletionFrom - 1, | ||
| deletionFrom, | ||
| "x", | ||
| "x", | ||
| ); | ||
| const nextChar = tr.doc.textBetween(deletionTo, deletionTo + 1, "x", "x"); |
Member
There was a problem hiding this comment.
I think these will blow up if at the very beginning or very end of the document, no? We may need to first confirm that there is a deletionFrom - 1 and deletionTo + 1.
Member
There was a problem hiding this comment.
(Apparently -1 is fine, but doc.content.size + 1 is not!)
(cherry picked from commit 470947c)
smoores-dev
force-pushed
the
remove-double-spaces
branch
from
August 27, 2025 14:30
564cdd2 to
8c02059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a "nice to have" feature. When a word is deleted and there are spaces on both sides they get merged, and only one space remains. Makes accepting deletions a bit better.
Added test.