replaceStep working across insertion ranges with multiple nodes - #19
Merged
smoores-dev merged 3 commits intoAug 27, 2025
Conversation
smoores-dev
previously approved these changes
Jul 31, 2025
smoores-dev
force-pushed
the
replace-step-multiple-inline-nodes
branch
from
August 27, 2025 15:07
943942d to
124f0aa
Compare
smoores-dev
previously approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During replaceSteps the deleted ranges were not correct ( rebase issue ), it caused errors when a replaceStep affected multiple inline nodes ( for example a range with different marks ).
Added test for proof.