Fix nested addMarkSteps inside insertions. - #20
Merged
smoores-dev merged 3 commits intoAug 27, 2025
Merged
Conversation
smoores-dev
force-pushed
the
add-mark-step-inline-nodes
branch
from
August 27, 2025 15:34
5c05751 to
b70b3e1
Compare
smoores-dev
previously approved these changes
Aug 27, 2025
Member
|
I ended up changing this quite a bit. The initial approach I had was flawed — I should have never been iterating over the nodes in the slice and applying suggestions to them. This meant that I was never applying suggestions/modifications on those nodes (and also was the source of the range error you ran into). Now, instead, we always operate on the whole doc, but can optionally provide a range for situations where we only care about applying suggestions to a slice of the doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off #18
Inside an existing suggestion if there was a Mark already a transaction was sent to add another Mark inside that there was a nodeSize error.
https://discuss.prosemirror.net/t/new-transform-with-leaf-text-node/8488/2 helps to understand the issue.