Export underlying implementation - #21
Merged
smoores-dev merged 2 commits intoAug 28, 2025
Merged
Conversation
smoores-dev
reviewed
Jul 31, 2025
| export { withSuggestChanges } from "./withSuggestChanges.js"; | ||
| export { | ||
| withSuggestChanges, | ||
| transformToSuggestionTransaction, |
Member
There was a problem hiding this comment.
Can you say more about the use case for this? I'm wary of committing this to the public API for the library unnecessarily — it means that any change to this in the future could be a breaking change, and I haven't really thought about its interface in those terms.
Contributor
Author
There was a problem hiding this comment.
We're using this on the backend and not just a plugin. The use case is that we're initialising an editor state, creating a transaction from it, do a lot of actions on that state and then before applying it we transform it with transformToSuggestionTransaction.
This way we don't have to think about interactions between suggestion mode and our actions during the transformations.
(cherry picked from commit cb4f67d)
smoores-dev
force-pushed
the
export-transform
branch
from
August 28, 2025 15:20
2116871 to
23cf949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.