Open
Conversation
This commit adds support for bundling Handsontable and Handsontable Pro using new file structure which currently exists on the develop branch. Additionally, in this commit, all dependencies were upgraded to the newest possible version and removed some part of code about detecting modules such as: "validator", "editor" and "renderer". The implementation has never been fully implemented. Issue: #29
This commit fixes issues related to building Handsontable where dist files are incorrectly marked as Pro (commercial license) or as CE (MIT). Additionally, usage description has been updated with the README file. Issue: #29
6 tasks
wszymanski
reviewed
Dec 12, 2018
| - [Building Handsontable Community Edition package from a local directory](https://asciinema.org/a/117464) | ||
| - [Building Handsontable package from the remote repository](https://asciinema.org/a/117465) | ||
| - [Building Handsontable package from a local directory](https://asciinema.org/a/117464) | ||
| - [Building Handsontable PRO package from the remote repository](https://asciinema.org/a/117462) |
Contributor
There was a problem hiding this comment.
Please update this line after Handsontable 7.0.0 release.
| moduleNamesToExclude.splice(moduleNamesToExclude.indexOf(module.name), 1); | ||
| } | ||
|
|
||
| module.getAllDependencies().forEach(function(dependency) { |
Contributor
There was a problem hiding this comment.
Maybe by using Array.filter the code would be yet more clear ;)? A decision about using it is up to you.
wszymanski
reviewed
Dec 12, 2018
Contributor
wszymanski
left a comment
wszymanski
left a comment
There was a problem hiding this comment.
Please change README after release. Everything else seems to be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for bundling Handsontable and Handsontable Pro using new file structure which currently exists on the
developbranch.Additionally, in this commit, all dependencies were upgraded to the newest possible version and removed some part of code about detecting modules such as: "validator", "editor" and "renderer". The implementation has never been fully implemented.
For reviewers/testers:
developbranch (https://github.com/handsontable/handsontable/tree/develop) can be used to test this changes;versionkey of thepackage.jsonfile for the Handsontable repository to7.0.0. Otherwise hot-builder reject the repository (https://github.com/handsontable/hot-builder/pull/30/files#diff-67ac0a10e6fd3203f52f4f88b45db601R8);