[fix] fix fa2a ops testcase#145
Merged
Merged
Conversation
GindaChen
approved these changes
Mar 5, 2026
GindaChen
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! We sure forgot to test out many of the unit tests after a refactor :( let me know if you hit others. Maybe this is a good time to let an agent do a pass...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug involving mismatched parameter passing.
bash:
NVTE_ALLOW_NONDETERMINISTIC_ALGO=0 torchrun --nnodes 1 --nproc_per_node 2 ./tests/test_fa2a_ops.py --world-size 2error log:
Traceback (most recent call last): File "/root/duanjunwen/DistCA/./tests/test_fa2a_ops.py", line 262, in <module> Traceback (most recent call last): File "/root/duanjunwen/DistCA/./tests/test_fa2a_ops.py", line 262, in <module> test(args) File "/root/duanjunwen/DistCA/./tests/test_fa2a_ops.py", line 197, in test test(args) File "/root/duanjunwen/DistCA/./tests/test_fa2a_ops.py", line 197, in test a2a_memcpy_non_cp( TypeError: a2a_memcpy_non_cp() got an unexpected keyword argument 'copy_seq_mask' a2a_memcpy_non_cp( TypeError: a2a_memcpy_non_cp() got an unexpected keyword argument 'copy_seq_mask'log after fix
copying rank 0 q shard to src buffer done. copying rank 0 q shard to src buffer done. copying rank 0 k shard to src buffer done. copying rank 0 k shard to src buffer done. copying rank 0 v shard to src buffer done. copying rank 0 v shard to src buffer done. copying rank 1 q shard to src buffer done. copying rank 1 q shard to src buffer done. copying rank 1 k shard to src buffer done. copying rank 1 k shard to src buffer done. copying rank 1 v shard to src buffer done. copying rank 1 v shard to src buffer done. copying rank 0 q shard from dst buffer done. copying rank 0 q shard from dst buffer done. copying rank 0 k shard from dst buffer done. copying rank 0 k shard from dst buffer done. copying rank 1 q shard from dst buffer done. copying rank 1 q shard from dst buffer done. copying rank 1 k shard from dst buffer done. copying rank 1 k shard from dst buffer done. copying rank 0 grads to send buffer done. copying rank 0 grads to send buffer done. copying rank 1 grads to send buffer done. copying rank 1 grads to send buffer done. copying rank 0 k shard from grad buffer done. copying rank 0 k shard from grad buffer done. copying rank 1 k shard from grad buffer done. copying rank 1 k shard from grad buffer done.