[fix] Fix latent handoff and FastWan-QAD example path#1557
Conversation
|
Rebased onto latest main, dropped the superseded The PR now keeps only the two still-needed fixes:
Validation: |
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
There was a problem hiding this comment.
Code Review
This pull request updates the FastWan_QAD_TAEHV.py example script with correct usage instructions and updated model defaults. It also introduces a helper function _prepare_worker_output_for_parent in multiproc_executor.py to move latent CUDA tensors to the CPU before sending them to the parent process, avoiding CUDA IPC issues for small latent outputs, and adds corresponding unit tests. The reviewer suggested improving the robustness of this helper function by handling cases where fastvideo_args might be None or lack the output_type attribute.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Pre-commit checks failedHi @aryan5v, the pre-commit checks have failed. To fix them locally: # Install pre-commit if you haven't already
uv pip install pre-commit
pre-commit install
# Run all checks and auto-fix what's possible
pre-commit run --all-filesCommon fixes:
After fixing, commit and push the changes. The checks will re-run automatically. For future commits, |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
bde00ce to
ab19210
Compare
|
This PR has merge conflicts with the base branch. Please rebase: git fetch origin main
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease |
Summary
Testing
Closes #1524