[ci] Clarify dashboard cohort grouping for legacy v1 records#1613
[ci] Clarify dashboard cohort grouping for legacy v1 records#1613macthecadillac wants to merge 10 commits into
Conversation
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
There was a problem hiding this comment.
Code Review
This pull request updates the performance dashboard to support v2 comparison identity, introducing explicit categorization for 'Legacy v1' and 'Invalid v2' records. It propagates comparison status, baseline status, and comparison reasons to the frontend, updating both the summary table and trend charts. The feedback focuses on improving the robustness of the frontend code in App.tsx by updating statusLabel, comparisonStatusLabel, and comparisonStatusClass to safely handle undefined or null values, which prevents potential runtime crashes when rendering legacy or incomplete records.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Maintainer follow-up: pandas promotes sparse result_schema_version=2 values to 2.0, so the Plotly path could merge a schema-only invalid-v2 record into Legacy v1. Commit 0a2fd25 fixes the numeric check and extends the existing grouping regression. An independent audit reproduced the bug; diff-check and py_compile passed. No local pytest ran on this Mac; automatic Fastcheck 4503 is the runtime gate. |
|
/test /performance |
Summary
Problem
The performance dashboards could present legacy v1 records alongside v2 benchmark records without clearly communicating their different comparison semantics. Incomplete v2 identities could also be mistaken for legacy data, making regression views and status labels ambiguous.
Solution
Dashboard ingestion now classifies records into complete v2, invalid v2, and legacy v1 cohorts using the canonical comparator identity-presence semantics.
Legacy records remain grouped by model and GPU as historical context. Complete v2 records retain workload, variant, benchmark, hardware, software, and recipe identity dimensions. Invalid v2 records remain isolated and show which identity fields are missing.
Both dashboard implementations now propagate and display comparison status, comparison reason, baseline status, schema version, and cohort kind.
Validation
34 passed, 16 warnings in 3.80sv22.17.1: passeduvx pre-commit run --all-files: passedgit diff --check upstream/main...HEAD: passedThe warnings were unrelated dependency deprecations.
Review
An independent reviewer identified an empty-identity-field edge case. An independent adjudicator accepted the finding, aligned both dashboard paths with the comparator, and added service and Plotly regressions. A fresh follow-up review found no actionable issues.
GPU Memory Impact
None. This changes CPU-side dashboard transformation, presentation, tests, and documentation only.
Remaining Risk
The React presentation changes have production-build coverage but no component-level rendering test.
Fixes #1535
Checklist
For model/pipeline changes, also check:
Not applicable: this change does not modify a model or pipeline.