refactor(face): add signal provider boundary#10
Draft
rich7420 wants to merge 2 commits into
Draft
Conversation
Make face_identify, face_enroll, face_update, and face_people return sanitized face-profile data only. Reject malformed successful DeepFace payloads instead of fabricating empty ids, and require face_update name at the schema boundary. Update iOS and web wording so person profiles and facts are described as PersonService-owned.
Add a shared FaceSignalProvider boundary around the legacy DeepFace index. Route PersonService and face compatibility tools through the provider so face remains a signal/index source while person/candidate decisions stay in PersonService.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves face recognition behind a signal-provider boundary so DeepFace remains a face index while PersonService owns person profiles, candidates, facts, and review decisions.
Summary
FaceSignalProviderand aDeepFaceFaceSignalProvidercompatibility adapter for identify/enroll/update/list/clear.PersonServicethrough face signals instead of a legacy person repository, keeping Unknown face matches as candidates until review.face_*tools on sanitized face-profile/index data only, rejecting malformed DeepFace success payloads instead of fabricating empty person IDs.Before: gateway/person paths could consume DeepFace profiles as if they were person records, so face matching and person ownership were still coupled.
After: face service/provider emits quality/match/profile-index signals; PersonService decides profile/candidate/fact outcomes; UI/tools consume the new bounded contract.
Validation
bun run typecheckbun test ./tests/e2e-person-rpc.ts ./tests/integration/test-tool-invoke.ts ./tests/test-person-methods.ts ./tests/test-person-identity-contracts.ts ./tests/test-people-methods.tsgit diff --check origin/main...HEADLimitations / Follow-ups