Skip to content

Fix Joi issue #2736:#2845

Open
martin-petersen wants to merge 1 commit intohapijs:masterfrom
martin-petersen:joi_issue_2736
Open

Fix Joi issue #2736:#2845
martin-petersen wants to merge 1 commit intohapijs:masterfrom
martin-petersen:joi_issue_2736

Conversation

@martin-petersen
Copy link
Copy Markdown
Contributor

  • fixes fork which was malfunctioning when schema uses id, the fork rules like, require some property, was not correctly applied.

   - fixes fork which was malfunctioning when schema uses of, the fork rules like, require some property, was not applied.
@martin-petersen
Copy link
Copy Markdown
Contributor Author

This PR fixes issue #2736

@martin-petersen martin-petersen marked this pull request as ready for review September 23, 2022 17:35
@Marsup
Copy link
Copy Markdown
Collaborator

Marsup commented Sep 29, 2022

I feel like it was intentional from the docs If no id is set, the schema id defaults to the object key it is associated with., not sure it was a bug 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants