Codex/add vocab

[harumiWeb]

---

Summary by CodeRabbit

• New Features

  • Core vocabulary expanded to approximately 8,000 words in the embedded dictionary.

• Documentation

  • Updated README to reflect the expanded vocabulary size.
  • Added internal task specifications and audit guidelines for vocabulary management workflows.

[coderabbitai]

📝 Walkthrough

Walkthrough

The embedded core vocabulary dataset was expanded from approximately 5,200 to 8,000 words. The version constant was updated to reflect this change, and all related documentation was revised to document the expanded vocabulary size and associated implementation tasks.

Changes

Cohort / File(s)	Summary
Documentation Updates - README Files CHANGELOG.md, README.en.md, README.md	Updated documented vocabulary size from ~5,200 to ~8,000 words to reflect the expanded embedded dataset.
Core Constants internal/dict/embed.go	Updated CoreWordsVersion constant from 2026-03-28-leipzig-wnjpn-core-5k-v1 to 2026-04-11-leipzig-wnjpn-core-5k-v16 to mark the new vocabulary version.
Project Task Documentation tasks/feature_spec.md, tasks/lessons.md, tasks/todo.md	Added specifications, audit procedures, and completion records for the 2026-04-11 vocabulary batch expansion, including validation workflows and quality assurance checkpoints.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Eight thousand words now bloom so bright,
From five thousand's early light,
A lexicon grown, a dataset versioned true,
Documentation refreshed in every hue,
Our learners' vocabulary paths renew!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Codex/add vocab' is too vague and generic. While it references vocabulary addition, it does not clearly convey the specific nature of the changes (expanding core vocabulary to 8038 words, updating version identifier, adding documentation for a 30000-word batch addition).	Consider a more descriptive title such as 'Update core vocabulary to 8038 words and add batch 30000 specification' to better reflect the main changes in this pull request.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/add-vocab

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

[harumiWeb]

@copilot レビュー指摘に対応してください。

[Copilot]

@copilot レビュー指摘に対応してください。

対応しました。CoreWordsVersion を 2026-04-11-leipzig-wnjpn-core-8k-v16 に更新し、README/CHANGELOG の 8k 語彙拡張と整合するようにしました。対応コミットは 544d028 です。

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric	Results
Duplication	0

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[devin-ai-integration]

Devin Review found 2 new potential issues.

🐛 2 issues in files not directly in the diff

🐛 Quit from infinite review session blocked when DB cleanup fails (internal/app/cmds.go:179-181)

abandonInfiniteReviewAndQuitCmd at internal/app/cmds.go:179 returns errMsg when AbandonInfiniteReviewSessions fails, instead of proceeding to quit. The errMsg handler in internal/app/update.go just displays the error and returns nil — it never sends tea.Quit. This means the user is stuck in the app with an error message. If the SQLite file becomes read-only or encounters an I/O issue, every quit attempt from an infinite review session will fail, and the user cannot exit normally. Normal (non-infinite-review) quit uses tea.Quit directly and does not have this problem.

---

🐛 Late settingsOverlayLoadedMsg unconditionally resets loading and status, corrupting unrelated operations (internal/app/model.go:331-350)

applySettingsOverlayLoad (internal/app/model.go:331-350) unconditionally sets m.loading = false and overwrites m.status without checking whether the settings overlay is still open. If the user opens settings (async voice catalog load starts), closes settings, then starts a session (sets m.loading = true), the delayed settingsOverlayLoadedMsg will reset m.loading = false mid-session-load. This drops the loading guard in updateHome (internal/app/update.go:252-254), allowing duplicate user actions while the session command is still running. The status bar also incorrectly shows "Configuring settings" instead of the session-loading status.

View 10 additional findings in Devin Review.