Add configurable startup update checks and release notes for v0.7.2#54
Add configurable startup update checks and release notes for v0.7.2#54
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 14 |
| Duplication | 14 |
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/harumiWeb/eitango/sessions/8ac3bf44-5877-4dc8-aa20-3dc32dd8ecc4 Co-authored-by: harumiWeb <164025931+harumiWeb@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new persisted setting to control whether the app performs an automatic update check on startup, exposes it in the home settings overlay and config.toml, and documents the change for the v0.7.2 release.
Changes:
- Add
startup_update_checkto config load/save with defaulttrue, and plumb it through app settings state. - Add a new settings row (“起動時更新チェック” / “Startup update check”) and handling to toggle + persist the value.
- Update READMEs and
CHANGELOG.mdto document the new toggle and release notes.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents startup update-check toggle and where to configure it |
| README.en.md | English documentation for the same toggle |
| internal/i18n/keys.go | Adds i18n key for the new settings row label |
| internal/i18n/i18n_test.go | Extends i18n key coverage test to include the new key |
| assets/locale/ja.toml | Adds Japanese label for the new settings row |
| assets/locale/en.toml | Adds English label for the new settings row |
| internal/config/config.go | Adds UpdateCheckEnabled to settings + TOML load/save (startup_update_check) |
| internal/config/config_test.go | Adds config parsing + round-trip coverage for the new TOML key |
| internal/app/model.go | Stores the setting in the model and uses it to gate startup update checks |
| internal/app/cmds.go | Updates updateCheckCmd to accept an enabled flag and return nil when disabled |
| internal/app/cmds_test.go | Adds test ensuring update check cmd is nil when disabled |
| internal/app/view.go | Renders a new settings row for startup update-check toggle |
| internal/app/view_test.go | Asserts the new settings row label appears in overlay rendering |
| internal/app/update.go | Implements left/right toggle behavior for the new row |
| internal/app/update_test.go | Adds tests for arrow-key toggle and persistence through save |
| CHANGELOG.md | Adds v0.7.2 entry and updates comparison links |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| m.renderSettingsRow(settingsRowQuestionCount, i18n.T(i18n.SettingsQuestions), m.settingsQuestionDisplay()), | ||
| m.renderSettingsRow(settingsRowWriteDifficulty, i18n.T(i18n.SettingsWriteDifficulty), m.settingsWriteDifficultyLabel()), | ||
| m.renderSettingsRow(settingsRowUpdateCheck, i18n.T(i18n.SettingsUpdateCheck), audioStateLabel(m.settingsUpdateCheckEnabled)), | ||
| m.renderSettingsRow(settingsRowAudioEnabled, i18n.T(i18n.SettingsAudioEnabled), audioStateLabel(m.settingsAudioEnabled)), | ||
| m.renderSettingsRow(settingsRowAudioVoice, i18n.T(i18n.SettingsAudioVoice), m.settingsAudioVoiceLabel()), |
There was a problem hiding this comment.
audioStateLabel(...) is now used to render the non-audio setting Startup update check. Since it sources its text from i18n.AudioStateOn/Off (under the [audio] locale table), this couples unrelated UI to the audio domain and the helper name is misleading. Consider introducing a more generic on/off label helper (and/or generic i18n keys) and using that here to keep semantics clear as more toggles are added.
This updates
eitangoso automatic update checks on startup can be turned on or off from both the settings UI andconfig.toml. It also rolls the user-visible change into thev0.7.2release notes.What changed
startup_update_checkto persisted settings, with default behavior unchanged (true)eitango versioncontinues to perform a manual release check regardless of the startup toggleConfig
config.tomlUI
起動時更新チェックStartup update checkDocs / release notes
README.md/README.en.mdto document the new togglev0.7.2inCHANGELOG.mdExample