Skip to content

Add configurable startup update checks and release notes for v0.7.2#54

Merged
harumiWeb merged 2 commits intomainfrom
copilot/add-update-check-toggle
Apr 11, 2026
Merged

Add configurable startup update checks and release notes for v0.7.2#54
harumiWeb merged 2 commits intomainfrom
copilot/add-update-check-toggle

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

This updates eitango so automatic update checks on startup can be turned on or off from both the settings UI and config.toml. It also rolls the user-visible change into the v0.7.2 release notes.

  • What changed

    • Added startup_update_check to persisted settings, with default behavior unchanged (true)
    • Added a new settings row in the home settings overlay to toggle startup update checks
    • Startup-time update checks now respect the saved setting
    • eitango version continues to perform a manual release check regardless of the startup toggle
  • Config

    • New config key:
      startup_update_check = false
    • This is loaded/saved through the existing strict TOML config path, so it can be managed either in the UI or directly in config.toml
  • UI

    • Added a dedicated settings item:
      • Japanese: 起動時更新チェック
      • English: Startup update check
    • The setting is rendered and persisted alongside the existing home settings options
  • Docs / release notes

    • Updated README.md / README.en.md to document the new toggle
    • Added the change under v0.7.2 in CHANGELOG.md
  • Example

    session_size = 10
    write_mode_difficulty = "basic"
    startup_update_check = false
    audio_enabled = true

  • settings update check toggle


Open with Devin

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 11, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 14 complexity · 14 duplication

Metric Results
Complexity 14
Duplication 14

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Agent-Logs-Url: https://github.com/harumiWeb/eitango/sessions/8ac3bf44-5877-4dc8-aa20-3dc32dd8ecc4

Co-authored-by: harumiWeb <164025931+harumiWeb@users.noreply.github.com>
Copilot AI changed the title [WIP] Add settings to enable or disable update checks Add configurable startup update checks and release notes for v0.7.2 Apr 11, 2026
Copilot AI requested a review from harumiWeb April 11, 2026 14:57
@harumiWeb harumiWeb marked this pull request as ready for review April 11, 2026 14:58
@harumiWeb harumiWeb requested a review from Copilot April 11, 2026 14:58
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new persisted setting to control whether the app performs an automatic update check on startup, exposes it in the home settings overlay and config.toml, and documents the change for the v0.7.2 release.

Changes:

  • Add startup_update_check to config load/save with default true, and plumb it through app settings state.
  • Add a new settings row (“起動時更新チェック” / “Startup update check”) and handling to toggle + persist the value.
  • Update READMEs and CHANGELOG.md to document the new toggle and release notes.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Documents startup update-check toggle and where to configure it
README.en.md English documentation for the same toggle
internal/i18n/keys.go Adds i18n key for the new settings row label
internal/i18n/i18n_test.go Extends i18n key coverage test to include the new key
assets/locale/ja.toml Adds Japanese label for the new settings row
assets/locale/en.toml Adds English label for the new settings row
internal/config/config.go Adds UpdateCheckEnabled to settings + TOML load/save (startup_update_check)
internal/config/config_test.go Adds config parsing + round-trip coverage for the new TOML key
internal/app/model.go Stores the setting in the model and uses it to gate startup update checks
internal/app/cmds.go Updates updateCheckCmd to accept an enabled flag and return nil when disabled
internal/app/cmds_test.go Adds test ensuring update check cmd is nil when disabled
internal/app/view.go Renders a new settings row for startup update-check toggle
internal/app/view_test.go Asserts the new settings row label appears in overlay rendering
internal/app/update.go Implements left/right toggle behavior for the new row
internal/app/update_test.go Adds tests for arrow-key toggle and persistence through save
CHANGELOG.md Adds v0.7.2 entry and updates comparison links

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/app/view.go
Comment on lines 197 to 201
m.renderSettingsRow(settingsRowQuestionCount, i18n.T(i18n.SettingsQuestions), m.settingsQuestionDisplay()),
m.renderSettingsRow(settingsRowWriteDifficulty, i18n.T(i18n.SettingsWriteDifficulty), m.settingsWriteDifficultyLabel()),
m.renderSettingsRow(settingsRowUpdateCheck, i18n.T(i18n.SettingsUpdateCheck), audioStateLabel(m.settingsUpdateCheckEnabled)),
m.renderSettingsRow(settingsRowAudioEnabled, i18n.T(i18n.SettingsAudioEnabled), audioStateLabel(m.settingsAudioEnabled)),
m.renderSettingsRow(settingsRowAudioVoice, i18n.T(i18n.SettingsAudioVoice), m.settingsAudioVoiceLabel()),
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audioStateLabel(...) is now used to render the non-audio setting Startup update check. Since it sources its text from i18n.AudioStateOn/Off (under the [audio] locale table), this couples unrelated UI to the audio domain and the helper name is misleading. Consider introducing a more generic on/off label helper (and/or generic i18n keys) and using that here to keep semantics clear as more toggles are added.

Copilot uses AI. Check for mistakes.
@harumiWeb harumiWeb merged commit dc94b43 into main Apr 11, 2026
12 checks passed
@harumiWeb harumiWeb deleted the copilot/add-update-check-toggle branch April 11, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

起動時のアップデートチェックを設定でONOFFできるようにする

3 participants