Skip to content

Fix issues in the Configuration section of the Cluster Network page#791

Merged
jillian-maroket merged 8 commits into
harvester:mainfrom
jillian-maroket:fix-issues
Jun 3, 2025
Merged

Fix issues in the Configuration section of the Cluster Network page#791
jillian-maroket merged 8 commits into
harvester:mainfrom
jillian-maroket:fix-issues

Conversation

@jillian-maroket

@jillian-maroket jillian-maroket commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Scope: v1.4, v1.5, v1.6
Issues fixed:

  • Missed suggestions in PR 640
    Example:
    Screenshot 2025-06-02 at 4 11 37 PM
  • Issues in legacy content
    Examples:
    Incorrect indentation resulted in a broken ordered list.
    Screenshot 2025-06-02 at 4 08 46 PM
    The information must be moved to where it is relevant. Also, we must avoid consecutive admonitions of the same type.
    Screenshot 2025-06-02 at 4 14 09 PM

Signed-off-by: Jillian <jillian.maroket@suse.com>
Signed-off-by: Jillian <jillian.maroket@suse.com>
@jillian-maroket jillian-maroket self-assigned this Jun 2, 2025
jillian-maroket and others added 2 commits June 2, 2025 15:15
Signed-off-by: Jillian <jillian.maroket@suse.com>
@github-actions

github-actions Bot commented Jun 2, 2025

Copy link
Copy Markdown
Name Link
🔨 Latest commit 5ae4daa
😎 Deploy Preview https://683ebab5db92aee502d1ee78--harvester-preview.netlify.app

Signed-off-by: Jillian <jillian.maroket@suse.com>
Signed-off-by: Jillian <jillian.maroket@suse.com>
@jillian-maroket jillian-maroket requested a review from starbops June 2, 2025 09:44
@jillian-maroket jillian-maroket marked this pull request as ready for review June 2, 2025 09:45
@github-actions github-actions Bot requested a review from akashraj4261 June 2, 2025 09:45
Signed-off-by: Jillian <jillian.maroket@suse.com>

@starbops starbops left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit. Thank you.

Comment thread docs/networking/clusternetwork.md Outdated
Signed-off-by: Jillian <jillian.maroket@suse.com>
@jillian-maroket jillian-maroket requested a review from starbops June 3, 2025 08:46

@starbops starbops left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@jillian-maroket jillian-maroket merged commit b9d5463 into harvester:main Jun 3, 2025
4 checks passed
@jillian-maroket jillian-maroket added the product-doc/added Content added to SUSE Virtualization doc label Jun 20, 2025
@jillian-maroket jillian-maroket deleted the fix-issues branch September 4, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product-doc/added Content added to SUSE Virtualization doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants