feat: add vm-migration-network setting#811
Conversation
|
innobead
left a comment
There was a problem hiding this comment.
In general, LGTM. Just a few feedback.
jillian-maroket
left a comment
There was a problem hiding this comment.
Review done. Note that the structural changes that I suggested here will be applied to the "Storage Network" page as well. I will create the PR after we merge this one.
|
|
||
| - The `ippools.whereabouts.cni.cncf.io` CRD exists. You can check this using the command `kubectl get crd ippools.whereabouts.cni.cncf.io`. In certain [upgrade scenarios](https://github.com/harvester/harvester/issues/3168), the Whereabouts CNI is not installed correctly. | ||
|
|
||
| - The IP range of the VM migration network is in the IPv4 CIDR format and must neither conflict nor overlap with Kubernetes cluster networks. You must exclude IP addresses that KubeVirt pods and the VM migration network must not use. The following addresses are reserved: `10.42.0.0/16`, `10.43.0.0/16`, `10.52.0.0/16` and `10.53.0.0/16`. |
There was a problem hiding this comment.
You already explained the IP range for the VM migration network, but why is it necessary to mention "the VM migration network must not use"? It’s a little confusing here.
There was a problem hiding this comment.
This is legacy text that was copied from the storage network doc and reorganized a bit. I recently updated the storage network doc. LMK if you want to reuse the wording that what Ivan and I agreed on:
https://docs.harvesterhci.io/v1.6/advanced/storagenetwork#prerequisites
There was a problem hiding this comment.
Remove You must exclude IP addresses that KubeVirt pods and the VM migration network must not use..
|
|
||
| :::info important | ||
|
|
||
| Specify an IP range in the IPv4 CIDR format. The number of IP addresses must be larger than or equal to the number of your cluster nodes. |
There was a problem hiding this comment.
The storage network is required for Longhorn pods for data plane (IM and share manager pods), while the VM migration network is needed for each VM/virt-launcher pod. I suggest updating the explanation of the IP range as below. WDYT?
cc @Vicente-Cheng @WebberHuang1118
| Specify an IP range in the IPv4 CIDR format. The number of IP addresses must be larger than or equal to the number of your cluster nodes. | |
| Specify an IP range in the IPv4 CIDR format. The number of IP addresses must be larger than or equal to the number of VMs. |
There was a problem hiding this comment.
Based on my testing, only virt-handler get live-migration IP like:
k8s.v1.cni.cncf.io/network-status: |-
[{
"name": "k8s-pod-network",
"ips": [
"10.52.0.93"
],
"default": true,
"dns": {}
},{
"name": "harvester-system/vm-migration-network-g2cr7",
"interface": "migration0",
"ips": [
"10.1.2.2"
],
"mac": "ae:20:fb:20:67:94",
"dns": {}
}]Other kubevirt pods including virt-lanucher, they don't have live-migration IP:
k8s.v1.cni.cncf.io/network-status: |-
[{
"name": "k8s-pod-network",
"ips": [
"10.52.1.32"
],
"default": true,
"dns": {}
}]
Each node has one virt-handler, I think we can just mention "cluster nodes" here.
There was a problem hiding this comment.
Yeah that's fair, the same as storage network.
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
1b49e7c to
736e471
Compare
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Problem:
Solution:
Related Issue(s):
harvester/harvester#5848
Test plan:
Additional documentation or context