fix: TransactionBaseModel.computeSignatureKey() must propagate exceptions - #2607
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2607 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 183 183
Lines 7410 7410
Branches 1478 1478
=======================================
Hits 7407 7407
Misses 3 3 🚀 New features to boost your workflow:
|
…to callers. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
ericleponner
force-pushed
the
2552_compute_signature_key
branch
from
April 7, 2026 10:39
76897a5 to
1da8a31
Compare
ericleponner
marked this pull request as ready for review
April 7, 2026 15:14
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the renderer transaction signature audit flow so that TransactionBaseModel.computeSignatureKey() no longer swallows mirror-node / cache lookup failures, enabling upstream code to detect and react to signature-key computation errors.
Changes:
- Make
TransactionBaseModel.computeSignatureKey()rethrow lookup errors after logging. - Update multiple callers to wrap
computeSignatureKey()intry/catchand apply fallbacks when it fails. - Adjust export filtering logic for “external signer only” flows to tolerate signature-key computation failures.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| front-end/src/renderer/utils/transactionSignatureModels/transaction.model.ts | Stops swallowing lookup exceptions and rethrows them so callers can handle failures. |
| front-end/src/renderer/pages/TransactionDetails/TransactionDetails.vue | Wraps signature-audit computation in try/catch and clears the audit on failure. |
| front-end/src/renderer/composables/useTransactionAudit.ts | Wraps signature-audit computation in try/catch and returns null on failure. |
| front-end/src/renderer/components/Transaction/Create/BaseTransaction/BaseTransaction.vue | Wraps transaction key computation in try/catch and falls back when it fails. |
| front-end/src/renderer/components/ExternalSigning/ExportTransactionsModal.vue | Adds try/catch around external-transaction filtering based on signature audit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ctionsModal.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Eric Le Ponner <91124272+ericleponner@users.noreply.github.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Kolpic
pushed a commit
that referenced
this pull request
Apr 15, 2026
…ions (#2607) * TransactionBaseModel.computeSignatureKey() now propagates exceptions to callers. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com> * Update front-end/src/renderer/components/ExternalSigning/ExportTransactionsModal.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Eric Le Ponner <91124272+ericleponner@users.noreply.github.com> * Fixed ExportTransactionsModal.handleExport(). Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com> * TransactionDetails.fetchTransaction() now post a toast in case of error. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com> * useTransactionAudit.signatureKey now send logger message. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com> --------- Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com> Signed-off-by: Eric Le Ponner <91124272+ericleponner@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changes below update
TransactionBaseModel.computeSignatureKey()method.Current method code swallows exceptions which prevents to use them for user error reporting.
Changes below make sure that:
TransactionBaseModel.computeSignatureKey()propagates errorsFor archive purpose, here is the calling tree of
TransactionBaseModel.computeSignatureKey():OKmeans code is already protected from bubbling errors.FIXEDmeans code is updated by this PR.Related issue(s):
Prerequisite for #2552
Notes for reviewer:
Checklist