fix: improve Sign action flow and error reporting

[ericleponner]

Description:

Changes below update SignTransactionController to improve error reporting.
They apply the same pattern as in SignAllController:

• they now produce a fine grain report by calling collectRequiredKeys(), collectMissingKeys() and signItems() and building an ActionReport
• they remove signTransactions() function which is now obsolete

Related issue(s):

Contributes to #2552

Notes for reviewer:

M   front-end/src/renderer/pages/TransactionDetails/SignTransactionController.vue
M   front-end/src/renderer/pages/Transactions/components/SignSingleButton.vue
    # Now calls collectRequiredKeys(), collectMissingKeys() and signItems()
    # in place of signTransactions(). Uses ActionReport to construct user feedback.
    # Removed (unused) signed boolean from props.callback().

M   front-end/src/renderer/pages/TransactionDetails/TransactionDetails.vue
    # Removed router.back() from fetchTransactions()

M   front-end/src/renderer/utils/index.ts
    # Removed now unused signTransactions()

M   front-end/src/tests/renderer/utils/index.spec.ts
    # Replaced unit tests for signTransactions() by tests 
    # for collectRequiredKeys(), collectMissingKeys() and signItems()

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (c1e68d6) to head (2b33bbb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         184      184           
  Lines        7446     7446           
  Branches     1489     1479   -10     
=======================================
  Hits         7443     7443           
  Misses          3        3           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR refactors the single-transaction signing flow to align with the existing “Sign All” pattern by producing more structured user-facing reports and by splitting signing into required-key collection, missing-key detection, and item signing.

Changes:

• Update SignTransactionController to use collectRequiredKeys(), collectMissingKeys(), and signItems() and return ActionReport-based feedback.
• Simplify SignSingleButton’s emitted payload (remove unused signed flag) and adjust transaction detail fetching behavior.
• Remove/rework signTransactions() usage and replace its unit tests with coverage for the newer helper functions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
front-end/src/renderer/pages/TransactionDetails/SignTransactionController.vue	Refactors signing flow to use ActionReport + helper functions and changes callback signature.
front-end/src/renderer/pages/Transactions/components/SignSingleButton.vue	Updates transactionSigned event payload and removes unused signed propagation.
front-end/src/renderer/pages/TransactionDetails/TransactionDetails.vue	Stops navigating back on fetch errors (now rethrows).
front-end/src/renderer/utils/index.ts	Adds early return for empty sign set, and removes/obsoletes signTransactions() (currently left as commented code).
front-end/src/tests/renderer/utils/index.spec.ts	Replaces signTransactions() tests with tests for collectRequiredKeys(), collectMissingKeys(), and signItems().

Comments suppressed due to low confidence (2)

front-end/src/renderer/utils/index.ts:288

• index.ts still contains the full old signTransactions() implementation commented out. Keeping large blocks of commented code makes maintenance harder and risks divergence from the real implementation. Since this function is now obsolete, it should be removed entirely (use git history for retrieval if needed).

export const splitMultipleAccounts = (input: string, client: Client): string[] => {
  input = input.trim();

  const result: string[] = [];
  if (!input) {
    return result;
  }

front-end/src/tests/renderer/utils/index.spec.ts:16

• These tests still set up and mock vue-toast-notification (toastErrorSpy/useToast), but the updated test suite no longer asserts on toast behavior and doesn't use the toast mock. Removing unused mocks/fixtures will reduce noise and make failures easier to diagnose.

export const toastErrorSpy = vi.fn();
const toastMock = { error: toastErrorSpy };

vi.mock('vue-toast-notification', () => ({
  useToast: () => toastMock,
}));

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[svienot]

LGTM