Skip to content

fix: import no longer brings up the Save dialog - #2611

Merged
ericleponner merged 1 commit into
mainfrom
2604-fix-export
Apr 7, 2026
Merged

fix: import no longer brings up the Save dialog#2611
ericleponner merged 1 commit into
mainfrom
2604-fix-export

Conversation

@svienot

@svienot svienot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Description:

  • restore the dev target to what is was before (which will allow showSaveDialog() to be called again)
  • add dev:attach target which sets-up the frontend to be able to attach the automation tests.

Related issue(s):

Fixes #2604

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
svienot requested a review from a team as a code owner April 7, 2026 15:58
@svienot
svienot requested a review from ericleponner April 7, 2026 15:58
@svienot svienot self-assigned this Apr 7, 2026
@svienot svienot added Bug A error that causes the feature to behave differently than what was expected based on design docs Regression Behavior that used to work in a released product or service that no longer works with a new release. Frontend Frontend development work labels Apr 7, 2026
@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (509bfd3) to head (367986e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2611   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         183      183           
  Lines        7410     7410           
  Branches     1478     1474    -4     
=======================================
  Hits         7407     7407           
  Misses          3        3           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericleponner ericleponner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericleponner
ericleponner merged commit 27cefbc into main Apr 7, 2026
26 of 27 checks passed
@ericleponner
ericleponner deleted the 2604-fix-export branch April 7, 2026 17:29
@steven-sheehy steven-sheehy added this to the v0.28.0 milestone Apr 7, 2026
Kolpic pushed a commit that referenced this pull request Apr 15, 2026
Restore 'dev' target and add 'dev:attach' target in front-end.

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work Regression Behavior that used to work in a released product or service that no longer works with a new release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression: export no longer brings up the Save dialog

3 participants