Skip to content

fix: updating cache after Import Signatures from File command - #2846

Merged
svienot merged 1 commit into
mainfrom
2845_transaction_state_after_import_signatures
May 13, 2026
Merged

fix: updating cache after Import Signatures from File command#2846
svienot merged 1 commit into
mainfrom
2845_transaction_state_after_import_signatures

Conversation

@ericleponner

Copy link
Copy Markdown
Contributor

Description:

Changes below make sure that BackendTransactionCache is updated after import signatures from a files.
This enables correct state to be displayed in transaction details.

Related issue(s):

Fixes #2845

Notes for reviewer:

M   front-end/src/renderer/pages/Transactions/Transactions.vue
    # importSignaturesFromV2File() now makes sure to clear all cached data for the import transactions.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ched data for imported transactions.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner
ericleponner requested a review from svienot May 13, 2026 17:37
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (6095dfa) to head (c618ed3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         184      184           
  Lines        7619     7619           
  Branches     1523     1538   +15     
=======================================
  Hits         7618     7618           
  Misses          1        1           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svienot svienot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericleponner
ericleponner marked this pull request as ready for review May 13, 2026 17:45
@ericleponner
ericleponner requested a review from a team as a code owner May 13, 2026 17:45
@ericleponner
ericleponner requested a review from jbair06 May 13, 2026 17:45
@ericleponner ericleponner self-assigned this May 13, 2026
@steven-sheehy steven-sheehy added Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work labels May 13, 2026
@steven-sheehy steven-sheehy added this to the v0.30.0 milestone May 13, 2026
@svienot
svienot merged commit 60f726f into main May 13, 2026
32 of 34 checks passed
@svienot
svienot deleted the 2845_transaction_state_after_import_signatures branch May 13, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction state is incorrect after Import Signatures from File command

3 participants