chore: remove unused DELETE /transaction-groups and DELETE /transactions endpoints - #3325
Merged
Conversation
…ints Both endpoints were dead code with no front-end callers and introduced unnecessary attack surface. Individual transaction cancel uses PATCH /transactions/cancel/:id; group cancel uses PATCH /transaction-groups/:id/cancel. Signed-off-by: John Bair <john.bair@swirldslabs.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 208 208
Lines 6534 6506 -28
Branches 1175 1197 +22
==========================================
- Hits 6533 6505 -28
Misses 1 1
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes two unused backend API deletion endpoints (DELETE /transactions/:id and DELETE /transaction-groups/:id) and their underlying service logic/tests, in line with Issue #3324 to eliminate dead code paths.
Changes:
- Deleted
TransactionsService.removeTransaction()and theDELETE /transactions/:idcontroller route plus related unit tests. - Deleted
TransactionGroupsService.removeTransactionGroup()and theDELETE /transaction-groups/:idcontroller route plus related unit tests. - Cleaned up related imports (e.g.,
Delete,emitTransactionUpdate) no longer needed after endpoint removal.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| back-end/apps/api/src/transactions/transactions.service.ts | Removes unused transaction deletion service method. |
| back-end/apps/api/src/transactions/transactions.service.spec.ts | Removes unit tests covering the deleted service method. |
| back-end/apps/api/src/transactions/transactions.controller.ts | Removes DELETE /transactions/:id route. |
| back-end/apps/api/src/transactions/transactions.controller.spec.ts | Removes unit tests for the deleted controller route. |
| back-end/apps/api/src/transactions/groups/transaction-groups.service.ts | Removes unused transaction-group deletion service method. |
| back-end/apps/api/src/transactions/groups/transaction-groups.service.spec.ts | Removes unit tests covering the deleted group removal behavior and updates imports. |
| back-end/apps/api/src/transactions/groups/transaction-groups.controller.ts | Removes DELETE /transaction-groups/:id route. |
| back-end/apps/api/src/transactions/groups/transaction-groups.controller.spec.ts | Removes unit tests for the deleted controller route. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3324
Neither endpoint had any front-end callers; both were dead code.