Skip to content

fix: improved UTF8 handling in file transaction display - #3370

Merged
jbair06 merged 2 commits into
mainfrom
utf8_handling
Sep 2, 2026
Merged

fix: improved UTF8 handling in file transaction display#3370
jbair06 merged 2 commits into
mainfrom
utf8_handling

Conversation

@ericleponner

@ericleponner ericleponner commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description:

Changes below improve UTF8 handling in FileContentsModal.displayContent.

Fixes:

TT-004

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@swirlds-automation

swirlds-automation commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (40dbd71) to head (72e2d04).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3370   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         213      213           
  Lines        6725     6725           
  Branches     1228     1230    +2     
=======================================
  Hits         6724     6724           
  Misses          1        1           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericleponner
ericleponner marked this pull request as ready for review September 2, 2026 10:31
@ericleponner
ericleponner requested a review from a team as a code owner September 2, 2026 10:31
@ericleponner
ericleponner requested a review from jbair06 September 2, 2026 10:31
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@steven-sheehy steven-sheehy added Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work labels Sep 2, 2026
@steven-sheehy steven-sheehy added this to the v0.38.0 milestone Sep 2, 2026
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

@jbair06 jbair06 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfies the requirements. LGTM

@jbair06
jbair06 merged commit 874275d into main Sep 2, 2026
28 checks passed
@jbair06
jbair06 deleted the utf8_handling branch September 2, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants