fix(controller): Allow wildcard resources with specific actions in rate limit config#6550
Draft
AbhiMgowda wants to merge 1 commit intomainfrom
Draft
fix(controller): Allow wildcard resources with specific actions in rate limit config#6550AbhiMgowda wants to merge 1 commit intomainfrom
AbhiMgowda wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
controller startup failure when configuring API rate limits with wildcard resources and specific actions, for example
resources = ["*"] and actions = ["read", "list"]Current behavior validates each requested action against every expanded resource. Some resources, like billing, do not support read/list and only expose custom actions. That causes config validation to fail with: action read not valid for resource billing and the controller does not initialize.
ratelimit_config
Files Changed
internal/daemon/controller/rate_limiter_test.go
internal/ratelimit/config.go
internal/ratelimit/config_test.go
I would like to propose changing wildcard action handling in rate-limit config from fail-fast to apply-where-valid. Explicit resource configs remain strict.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.