Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // we use the PHP tag as passthrough "tag" because is simply ignored by the `hashHTMLBlocks` function in Showdown | ||
| // see: https://github.com/showdownjs/showdown/blob/master/src/subParsers/makehtml/hashHTMLBlocks.js#L93-L95 | ||
| return `\n<?php start="content-block" type="${type.toLowerCase()}" ?>\n${content}\n<?php end="content-block" type="${type.toLowerCase()}" ?>\n`; | ||
| return `\n<?php start="content-block" type="${type.toLowerCase()}" ?>\n\n${content}\n\n<?php end="content-block" type="${type.toLowerCase()}" ?>\n`; |
There was a problem hiding this comment.
This change is to fix an edge case I noticed that broke recently. It only broke on the dodont testing page
this do don't testing example that only contained an inline code snippet was treated as a full code block
but this doesn't work when I removed ember prism
when the code snippet had other text, it never broke. here is an example:
Now, with this the normal inline code snippets still work + when the do/dont only includes an inline code snippet it works.
| } | ||
|
|
||
| // TODO! fix this once Alex has completed the work on the code blocks | ||
| .doc-code-block__code-snippet, |
There was a problem hiding this comment.
Kind of made the executive decision that you can't put a full demo in a do/dont. Theres no instances of this currently and it seems like a not ideal UX.
| @include doc-font-style-body-small(); | ||
| } | ||
|
|
||
| .doc-code-block__code-snippet, |
There was a problem hiding this comment.
Kind of made the executive decision that you can't put a full demo in a banner. Theres no instances of this currently and it seems like a not ideal UX.
| @include doc-font-style-body-small(); | ||
| } | ||
|
|
||
| .doc-code-block__code-snippet, |
There was a problem hiding this comment.
Kind of made the executive decision that you can't put a full demo in a banner. Theres no instances of this currently and it seems like a not ideal UX.
1 participant
📌 Summary
If merged, this PR would remove the ember-prism dependency from the website.
This includes a few changes:
ember-cli-build.jsprism-draculastylesCodeBlockcomponent styles + any references to the code block classes```to code blocks🔗 External links
Jira ticket: HDS-5834
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.