Skip to content

Update test to use randomKeyValue for keys & values instead of randomstring#1296

Merged
Uk1288 merged 1 commit intomainfrom
random-uuid-generates-strings-starting-with-numbers
Mar 20, 2026
Merged

Update test to use randomKeyValue for keys & values instead of randomstring#1296
Uk1288 merged 1 commit intomainfrom
random-uuid-generates-strings-starting-with-numbers

Conversation

@Uk1288
Copy link
Copy Markdown
Contributor

@Uk1288 Uk1288 commented Mar 20, 2026

Previously the test was using randomstring to generate key & value strings. The api expects keys & values to start with letter or underscore but the randomstringperiodically generates strings starting with numbers. randomstring has been replaced with randomKeyValue which always starts with a letter.

=== FAIL: . TestPolicySetParametersDelete (1.60s)
    helper_test.go:976: invalid attribute
        
        Key must start with a letter or underscore (_). Use only letters, numbers, and underscores.

=== FAIL: . TestPolicySetParametersDelete (re-run 1) (1.57s)
    helper_test.go:976: invalid attribute
        
        Key must start with a letter or underscore (_). Use only letters, numbers, and underscores.

=== FAIL: . TestPolicySetParametersDelete (re-run 2) (1.65s)
    helper_test.go:976: invalid attribute
        
        Key must start with a letter or underscore (_). Use only letters, numbers, and underscores.

=== FAIL: . TestPolicySetParametersDelete (re-run 3) (1.52s)
    helper_test.go:976: invalid attribute
        
        Key must start with a letter or underscore (_). Use only letters, numbers, and underscores.

@Uk1288 Uk1288 requested a review from a team as a code owner March 20, 2026 08:12
@Uk1288 Uk1288 added the no-changelog-needed check changelog entry github workflow label Mar 20, 2026
Copy link
Copy Markdown
Contributor

@Maed223 Maed223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looking good!

@Uk1288 Uk1288 merged commit 729a4a0 into main Mar 20, 2026
16 of 17 checks passed
@github-actions
Copy link
Copy Markdown

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@Uk1288 Uk1288 deleted the random-uuid-generates-strings-starting-with-numbers branch March 20, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed check changelog entry github workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants