Prepare stacks integration tests for tfe release#1298
Open
aaabdelgany wants to merge 7 commits intomainfrom
Open
Prepare stacks integration tests for tfe release#1298aaabdelgany wants to merge 7 commits intomainfrom
aaabdelgany wants to merge 7 commits intomainfrom
Conversation
Lets see what breaks
|
…icorp/go-tfe into abdu/remove_stacks_test_skips
aaabdelgany
changed the title
skipunlessbeta from the stacks tests
arunatibm
reviewed
Apr 10, 2026
| "testing" | ||
| ) | ||
|
|
||
| func stackVCSRepoIdentifier(t *testing.T) string { |
arunatibm
reviewed
Apr 10, 2026
| return githubIdentifier | ||
| } | ||
|
|
||
| func stackVCSRepoBranch() string { |
arunatibm
reviewed
Apr 10, 2026
| type StackDiagnostics interface { | ||
| // Read retrieves a stack diagnostic by its ID. | ||
| Read(ctx context.Context, stackConfigurationID string) (*StackDiagnostic, error) | ||
| // Acknowledge marks a diagnostic as acknowledged. |
Contributor
There was a problem hiding this comment.
This is cleanup since it's not used anymore right? I remember this was discussed on slack or a call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the beta skip flags in all of the stacks integration tests to ensure that they start running in CI. It also removes any references to
stack_diagnostics#acknowledgewhich is something that was removed as part of the Stacks GA release and we just happened to miss it in go-tfe.Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
Changes to Security Controls