Update instance name logic in GCP packer plugin startup script - #355
Merged
Conversation
Get instance name via metadata server instead of using ${HOSTNAME}
Depending on the OS, ${HOSTNAME} can resolve to the FQDN (ie: `{NAME}.{ZONE}.c.{PROJECT}.internal`) which causes the startup script to fail during completion, even if all other tasks were successful.
|
|
duncanspani
changed the title
duncanspani
changed the title
tanmay-hc
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get instance name via metadata server instead of using ${HOSTNAME}
Some Linux distros on GCP allows the ${HOSTNAME} to resolve to the FQDN by default (ie:
{NAME}.{ZONE}.c.{PROJECT}.internal) which causes the startup script to throw an error during completion, even if all other tasks were successful. This errors results in the metadata never being updated and the startup script running forever.This change removes the only reference to the HOSTNAME env var, and replaces it with the name returned by the GCP metadata server (similar to ZONE in this same file).