r/aws_bedrockagentcore_gateway_target: add inference target configuration#48705
Open
jesseturner21 wants to merge 6 commits into
Open
r/aws_bedrockagentcore_gateway_target: add inference target configuration#48705jesseturner21 wants to merge 6 commits into
jesseturner21 wants to merge 6 commits into
Conversation
…al_provider_configuration
…ough fwflex to unwrap pointer union
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
Bot
added
needs-triage
…oint https validator
justinretzolk
added
enhancement
…ix.strip and mcp endpoint validator bugs - provider_prefix.strip is Optional+Computed with a false default. The SDK models ProviderPrefix.Strip as a non-pointer bool that the service defaults to false and always returns from Get, so a plain Optional produced "Provider produced inconsistent result after apply" (planned null, but now cty.False) on any inference target whose provider_prefix omitted strip, tainting the resource. Optional+Computed+booldefault.StaticBool(false) absorbs the server value. - Anchor the mcp_server endpoint validator to ^https://.+ (was https://.*). Unanchored, RegexMatches accepted any string merely containing https:// (e.g. ftp://x-https://y); this mirrors the inference provider endpoint validator. Add acctests: an inference provider_prefix without strip that must apply cleanly and re-plan empty, and an mcp_server endpoint that must be rejected at plan time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
inferencetarget configuration block toaws_bedrockagentcore_gateway_target— the third member of the top-level target-configuration union (alongsidehttpandmcp). Supports both theconnectorandprovidervariants; the provider variant exposesendpoint,model_mapping(provider_prefixwithseparator/strip), andoperations(path,provider_path,models). Maps toInferenceTargetConfigurationin the AgentCore Control API.Source
aws/aws-sdk-go-v2@8881653298eb2d13cc8b60910bd7c2e8b6642df4(service/bedrockagentcorecontrol,InferenceTargetConfiguration/InferenceProviderTargetConfiguration)Testing
Caveats for reviewers
inferencetarget is a nested union with list-of-object members (operations→models); the Expand/Flatten round-trip is exercised by the acceptance test (live create + read) but warrants a review of the nested flattening.