This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Bump dependencies & go version to resolve #465 - #466
Open
andrewesweet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A relatively straightforward bumping of dependencies (in particular
google.golang.org/api) resolved #465. The quota project set in the Application Default Credential remains unrespected, but the environment variable is now respected so the data sources are usable as a non-service-account user.Bumping
google.golang.org/apito the latest version in turn bumpedgolang.org/x/oauth2which lead to errors when building with go 1.16:I resolved this by bumping the go version to 1.19. Why that version? Arbitrarily because that is what is presently used by the google provider.
Unfortunately, I lack the dependencies needed to run a full regression test of the provider, so I am at the maintainers' mercy to support that.