This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Resolve bug in validation of a chrome_policy resource with multiple schema_values of differing type - #472
Open
w0de wants to merge 2 commits into
Open
Resolve bug in validation of a chrome_policy resource with multiple schema_values of differing type#472w0de wants to merge 2 commits into
w0de wants to merge 2 commits into
Conversation
…hemas. Select only the relevant field schema.
w0de
changed the title
|
Would be good to get eyes on this issue. It's still a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeks to resolve #471
changes
Validation of chrome policy schema_values now expects there to always be exactly one proto field for any given schema_value. Previously all values were validated iteratively against all proto fields. This change seems reasonable - I don't believe it breaks an edge case. My test workspace's full policy schema does not have any schemas with conflicting field names.
But I'm unsure why the validation was first written this way. Concerning - Chesteron's fence, etc. (Git blame points to the initial commit only.) It may simply be a mistake which arose from a misunderstanding of (or changes in) schema structure. Or the misunderstanding may turn out to be mine :)!
I've added a relevant test case.