Fix #1464: Store set_sensitive values separately from computed values to prevent leakage in plan output - #1847
Open
dennismdejong wants to merge 1 commit into
Open
Conversation
…ed values to prevent leakage in plan output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
set_sensitivevalues are used and any other value changes, the plan output previously leaked the full content of the sensitive values in plaintext in the values section of the plan output.Root cause:
set_sensitivevalues were merged into the base values map viagetValues(), and the merged result (including sensitive content) was stored in the computedmetadata.valuesfield viasetReleaseAttributes. Sincemetadata.valuesis not marked sensitive, the entire merged values (including sensitive content) appeared in plan output when a diff occurred.Fix:
getNonSensitiveValues()that processes only non-sensitive inputs (values,set,set_list), excludingset_sensitivesetReleaseAttributesto buildmetadata.valuesfrom non-sensitive inputs onlyset_sensitive) still happens at apply time viagetValues()when actually runninghelm install/upgradeTestAccResourceRelease_cloakValuestest to expect empty metadata.values since sensitive values are no longer stored there