Feat #1596: Support OCI chart digest notation (@sha256:) in chart references - #1848
Open
dennismdejong wants to merge 1 commit into
Open
Feat #1596: Support OCI chart digest notation (@sha256:) in chart references#1848dennismdejong wants to merge 1 commit into
dennismdejong wants to merge 1 commit into
Conversation
…chart references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Helm supports installing charts by OCI digest (e.g.,
oci://registry-1.docker.io/bitnamicharts/postgresql@sha256:...), but the provider rejected it with invalid tag errors.Changes
chartDigest()helper function to detect@sha256:digest notation in chart referenceschartPathOptions()in the release resource to detect digest references, keep them in the chart URL instead ofcpo.Version, and skip settingcpo.Versionwhen a digest is usedchartPathOptionsModel()in the template data source with the same logicoci://registry/repo/chart@sha256:abc)sha256:abc)Closes #1596