Fix #1812: Preserve user's chart path expression instead of resolved absolute path in plan state - #1850
Open
dennismdejong wants to merge 1 commit into
Open
Conversation
…resolved absolute path in plan state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using a local directory path for the
chartattribute on HCP Terraform Stacks (where plan and apply run in separate ephemeral job directories), Terraform core produces an "inconsistent final plan" error because the planned.chartvalue contains the absolute path from the plan-time working directory, which differs at apply time.Root Cause
On HCP Terraform Stacks, Terraform evaluates
path.moduleto an absolute path during plan. This absolute-path value is stored in the plan for thechartattribute. At apply time,path.moduleresolves to a different directory, causing the inconsistency.Fix
Added a custom plan modifier (
localChartPathPlanModifier) on thechartattribute that:This ensures the chart path from a previous apply is carried forward when the resolved absolute path differs only due to environment differences (as happens on HCP Terraform Stacks).