Skip to content

Fix #1652, #1647: Fix v3 migration diffs for metadata, postrender, set_list defaults, and version normalization - #1852

Open
dennismdejong wants to merge 2 commits into
hashicorp:mainfrom
dennismdejong:fix/1652-v3-unexpected-diff
Open

Fix #1652, #1647: Fix v3 migration diffs for metadata, postrender, set_list defaults, and version normalization#1852
dennismdejong wants to merge 2 commits into
hashicorp:mainfrom
dennismdejong:fix/1652-v3-unexpected-diff

Conversation

@dennismdejong

Copy link
Copy Markdown

Changes

Fixes unexpected diffs encountered during v3 plugin framework migration:

helm/resource_helm_release.go

  • Fix v-prefix version diff: Use .ValueString() instead of .String() in ModifyPlan version comparison so TrimPrefix("v") correctly compares versions regardless of leading 'v'.
  • Fix metadata recompute: Use versionsEqual() for version comparison in recomputeMetadata to handle v-prefix differences.
  • Fix set ordering diffs: Compare set, set_sensitive, and set_list entries order-independently by sorting before comparison, preventing false diffs when the server returns entries in different order.

helm/resource_helm_release_stateupgrader.go

  • Fix postrender null diff: Preserve old null/empty postrender as null instead of creating an empty object with default values.
  • Fix set_wo_revision default: Change default from 1 to 0 when write-only sets are not used.

Related Issues

…ta, postrender, set_list defaults, and version normalization
@dennismdejong
dennismdejong requested review from a team, iam404 and rigalGit as code owners July 27, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

1 participant