Fix #372: Fetch and compare deployed Helm values in Read to detect out-of-band drift - #1856
Open
dennismdejong wants to merge 1 commit into
Open
Fix #372: Fetch and compare deployed Helm values in Read to detect out-of-band drift#1856dennismdejong wants to merge 1 commit into
dennismdejong wants to merge 1 commit into
Conversation
…detect out-of-band drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When values of a helm release are modified outside of Terraform (e.g., via
helm upgrade --set), the provider does not detect the drift. The Read function returns the state values rather than the actual deployed values.Root Cause
In the
Readfunction,setReleaseAttributesonly updatesmetadata.values(a computed-only field) but never compares or updatesstate.Values,state.Set,state.SetSensitive, orstate.SetListagainst the actual deployed values fromrelease.Config. This means out-of-band changes viahelm upgradeare invisible to Terraform.Fix
In the
Readfunction, aftersetReleaseAttributes, the fix:release.ConfiggetValues(ctx, &state)reflect.DeepEqualstate.ValuesThis also fixes #472 (drift from failed applies) - when a
helm upgradefails partway, the partially-applied values cause a mismatch that will be detected on the next read.Testing