Feat #1562: Support dynamic type for values attribute enabling structured diff output - #1861
Open
dennismdejong wants to merge 1 commit into
Open
Feat #1562: Support dynamic type for values attribute enabling structured diff output#1861dennismdejong wants to merge 1 commit into
dennismdejong wants to merge 1 commit into
Conversation
…ng structured diff output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
valuesattribute now usestypes.Dynamicinstead oftypes.List, allowing users to pass structured objects directly instead of only raw YAML strings in a list.Changes
Valuesfield fromtypes.Listtotypes.Dynamicin bothHelmReleaseModelandHelmTemplateModelschema.ListAttributetoschema.DynamicAttributegetValues()andgetValuesModel()to handle both:types.Object(new): structured map/object values are converted tomap[string]interface{}and mergedtypes.List(backward compatible): existing YAML string list format continues to workdynamicObjectToMap()andattrValueToNative()helper functions for recursive conversion of Terraform typestftypes.DynamicPseudoTypeImportStateto usetypes.DynamicNull()Backward Compatibility
Existing configurations using
values = ["yaml: string"]continue to work unchanged. Users can now also usevalues = { key = "value" }for structured input.